Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AIX Support to the collector #1652

Open
wants to merge 13 commits into
base: release/v1.63.0
Choose a base branch
from
Open

Add AIX Support to the collector #1652

wants to merge 13 commits into from

Conversation

Dylan-M
Copy link
Collaborator

@Dylan-M Dylan-M commented May 13, 2024 •
edited
Loading

  • feat(AIX): = Enable building and deploying the collector for AIX

Proposed Change

Add AIX support to the collector.

Checklist
  • Changes are tested
  • CI has passed

@Dylan-M Dylan-M requested a review from jsirianni May 13, 2024 19:29
@Dylan-M Dylan-M self-assigned this May 13, 2024
jsirianni

This comment was marked as resolved.

Sign in to view

@Dylan-M

This comment was marked as resolved.

Sign in to view
@Dylan-M

This comment was marked as resolved.

Sign in to view
cpheps
cpheps suggested changes May 14, 2024
View reviewed changes
config/example.yaml Outdated Show resolved Hide resolved
factories/exporters.go Outdated Show resolved Hide resolved
factories/processors_aix.go Show resolved Hide resolved
@Dylan-M Dylan-M force-pushed the aix branch 2 times, most recently from edd34a5 to 1891329 Compare May 14, 2024 22:00
@Dylan-M Dylan-M changed the base branch from release/v1.51.0 to release/v1.52.0 May 15, 2024 23:16
@Dylan-M Dylan-M force-pushed the aix branch 2 times, most recently from 71930de to 99e2834 Compare May 18, 2024 16:36
@Dylan-M Dylan-M requested a review from dpaasman00 as a code owner May 18, 2024 16:36
jsirianni
jsirianni requested changes May 20, 2024
View reviewed changes
factories/processors_aix.go Outdated Show resolved Hide resolved
factories/exporters_aix.go Outdated Show resolved Hide resolved
factories/processors_aix.go Outdated Show resolved Hide resolved
factories/receivers_aix.go Show resolved Hide resolved
updater/internal/path/path_unix.go Outdated Show resolved Hide resolved
@Dylan-M Dylan-M force-pushed the aix branch 2 times, most recently from f21cdf1 to 6e96f2a Compare May 28, 2024 23:50
@Dylan-M Dylan-M changed the base branch from release/v1.52.0 to release/v1.53.0 June 3, 2024 13:19
@Dylan-M Dylan-M force-pushed the aix branch 3 times, most recently from 37e0fa8 to 5dba843 Compare June 7, 2024 16:07
jsirianni

This comment was marked as outdated.

Sign in to view

@Dylan-M Dylan-M changed the base branch from release/v1.53.0 to release/v1.54.0 June 12, 2024 19:36
@Dylan-M Dylan-M added the enhancement New feature or request label Jun 20, 2024
@Dylan-M

This comment was marked as outdated.

Sign in to view
@BinaryFissionGames
Copy link
Contributor

@ryancgoins @jsirianni @dpaasman00 @BinaryFissionGames

Hey gents, I've just refreshed this PR this morning to bring it up to the current "default" release branch. I know the hardware isn't ready yet (yes, we have an actual Power server now that will run AIX), but I'm trying to be as prepped for that as possible ahead of time.

Were there any outstanding comments that need addressed beforehand? I know we had some discussion around changing some of the scripts to where AIX has its own unique ones instead of shared. Is that still a concern?

No high level concerns here. I'm fine with the script being shared between linux and AIX (it is called install_unix.sh after all).

@Dylan-M Dylan-M changed the base branch from release/v1.59.0 to release/v1.60.0 September 3, 2024 19:19
@Dylan-M Dylan-M changed the base branch from release/v1.60.0 to release/v1.61.0 September 26, 2024 02:12
@Dylan-M Dylan-M marked this pull request as draft September 26, 2024 02:18
@Dylan-M Dylan-M marked this pull request as ready for review September 26, 2024 02:18
@Dylan-M Dylan-M changed the base branch from release/v1.61.0 to release/v1.63.0 October 17, 2024 00:24
Dylan Myers added 13 commits October 25, 2024 08:13
@Dylan-M
Rebuild initial pass at AIX to avoid complicated rebase
f4564f0
@Dylan-M
Add goreleaser yaml file
05f08bf
@Dylan-M
Explicitly set config to version 2, and change the parameter that bre…
2374ebc 
…aks it
@Dylan-M
Add a comment to make it clear why the backup function is emtpy
10f529c
@Dylan-M
Make uninstall actually work, and clear up a bunch of the comments
45e8088
@Dylan-M
Finalize updater service manager and updater service tests
4b6ca60
@Dylan-M
Add Makefile changes
5b30216
@Dylan-M
Fix folder bug for aix env file
146f34f
@Dylan-M
Make sure storage dir exists for AIX
90fb09d
@Dylan-M
Add protection for the --file option when the file doesn't exist
b6e9121
@Dylan-M
Add AIX messages, and status for all, to the agent information output…
1e2a73a 
… of install script
@Dylan-M
Add missing escapes for double quotes inside of double quotes
62a63a9
@Dylan-M
Strip receivers down to bare minimums based on what runs on AIX
b4afa1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpheps cpheps cpheps requested changes

@BinaryFissionGames BinaryFissionGames Awaiting requested review from BinaryFissionGames

@dpaasman00 dpaasman00 Awaiting requested review from dpaasman00 dpaasman00 is a code owner

@ryancgoins ryancgoins Awaiting requested review from ryancgoins

@jsirianni jsirianni Awaiting requested review from jsirianni

At least 1 approving review is required to merge this pull request.

Assignees

@Dylan-M Dylan-M

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dylan-M @jsirianni @BinaryFissionGames @cpheps